@thibsy @thojou

Hello @thibsy,

the reason for why i surrounded return $this→modal?→getForm()?→getInputGroup()?→getContent(); with a try-catch in the first place was, to exactly prevent this type of error (Failed pipeline). The issue is that you can run Inline::getResult without previously attaching the current request to the modal which than leads to a Form handling issue. Previously when Inline::getResult was called, it was checked whether a POST Request was available. If so, it was appended to the modal and the Modals content was returned. If not, null was returned. The resulting behavior thus did not change here. IMHO it should be the users responsibility, to first call Inline::withRequest before calling Inline::getResult. If they do not, they will get null as a result. Inline::withRequest should be the only method responsible for binding the Request to the Modal and Inline Launcher itself (separation of concerns).

If you want to get rid of the try-catch, i would propose something like this. First check if a POST Request is available in the Modal. If not, return null, otherwise, return the content of the Modal. The key difference here is, that the request is not added to the Modal if not specifically intended by the user.

Alternatively, i can revert the Inline::getResult to how it was before.

What do you think?

Best regards
@matheuszych